Add support for snowflake connector #349
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure destination get a task context which allows for offset resets. Add the ability to retry an reset offset Set topic to the autogenerated schema name when schema cannot be established (NULL sink records/deletes) Add an serial offset generator
|
hariso
reviewed
Jan 30, 2024
| private void doWrite(Record rec) { | ||
| SinkRecord sinkRecord = toSinkRecord(rec); | ||
| private void doWriteWithOffsetRetry(Record rec) { | ||
| synchronized (taskCtx) { |
There was a problem hiding this comment.
I guess this is because you think we might write multiple records at the same time. If that's the case, I don't think Conduit will ever send a batch before the previous one is "done".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure destination get a task context which allows for offset resets. Add the ability to retry an reset offset
Set topic to the autogenerated schema name when schema cannot be established (NULL sink records/deletes) Add an serial offset generator