-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CLI): add connectors describe #2082
Conversation
Co-authored-by: Lovro Mažgon <[email protected]>
Co-authored-by: Lovro Mažgon <[email protected]>
Co-authored-by: Lovro Mažgon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve, as the command in question here is looking good 👍
However, let me point out that in pipeline describe
we now have the discrepancy between how a connector is shown vs. how a processor is shown. Arguably, connectors are even more important, but we only show their ID and plugin. How about we do the same thing for connectors and show the whole description of the connector? Essentially showing the whole pipeline config. WDYT?
The discrepancy I'm talking about:
@lovromazgon You're right. I'll make that change |
@lovromazgon will make sure I address that as part of #1911 separately. |
Description
Quick checks