Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CLI): add connectors describe #2082

Merged
merged 12 commits into from
Jan 21, 2025
Merged

feat(CLI): add connectors describe #2082

merged 12 commits into from
Jan 21, 2025

Conversation

raulb
Copy link
Member

@raulb raulb commented Jan 17, 2025

Description

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb raulb mentioned this pull request Jan 17, 2025
4 tasks
@raulb raulb marked this pull request as ready for review January 21, 2025 12:43
@raulb raulb requested a review from a team as a code owner January 21, 2025 12:43
cmd/conduit/internal/print_utils.go Outdated Show resolved Hide resolved
cmd/conduit/root/connectors/describe.go Outdated Show resolved Hide resolved
cmd/conduit/root/pipelines/describe.go Outdated Show resolved Hide resolved
cmd/conduit/root/pipelines/describe.go Outdated Show resolved Hide resolved
@raulb raulb requested a review from lovromazgon January 21, 2025 14:59
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve, as the command in question here is looking good 👍

However, let me point out that in pipeline describe we now have the discrepancy between how a connector is shown vs. how a processor is shown. Arguably, connectors are even more important, but we only show their ID and plugin. How about we do the same thing for connectors and show the whole description of the connector? Essentially showing the whole pipeline config. WDYT?

The discrepancy I'm talking about:

Screenshot 2025-01-21 at 16 17 18

@raulb
Copy link
Member Author

raulb commented Jan 21, 2025

I'll approve, as the command in question here is looking good 👍

However, let me point out that in pipeline describe we now have the discrepancy between how a connector is shown vs. how a processor is shown. Arguably, connectors are even more important, but we only show their ID and plugin. How about we do the same thing for connectors and show the whole description of the connector? Essentially showing the whole pipeline config. WDYT?

The discrepancy I'm talking about:

Screenshot 2025-01-21 at 16 17 18

@lovromazgon You're right. I'll make that change

@raulb raulb mentioned this pull request Jan 21, 2025
42 tasks
@raulb
Copy link
Member Author

raulb commented Jan 21, 2025

@lovromazgon will make sure I address that as part of #1911 separately.

@raulb raulb merged commit ac8fff0 into main Jan 21, 2025
3 checks passed
@raulb raulb deleted the cli-connectors-describe branch January 21, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: conduit connectors describe ID
2 participants