Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

describe connector plugins command #2086

Merged
merged 3 commits into from
Jan 22, 2025
Merged

describe connector plugins command #2086

merged 3 commits into from
Jan 22, 2025

Conversation

maha-hajja
Copy link
Contributor

@maha-hajja maha-hajja commented Jan 21, 2025

Description

describes a specific connector plugin.
the parameters' order in the table is as follows:

  1. required params
  2. other connector specific params
  3. sdk params

example: ./conduit connector-plugin desc builtin:[email protected]

image

Fixes #2024

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@maha-hajja maha-hajja requested a review from a team as a code owner January 21, 2025 21:50
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving ahead of time, but I think before we ship the two PRs (this one and #2088), we should:

  1. Consolidate the look of all tables so they're consistent (fwiw, I'm ok with the default style since I agree that on describe, it reads better).
  2. Hide those fields that are empty.

(Bonus is filing an issue for why author is always empty).

cmd/conduit/internal/print_utils.go Show resolved Hide resolved
@maha-hajja maha-hajja merged commit 643a331 into main Jan 22, 2025
3 checks passed
@maha-hajja maha-hajja deleted the maha/desc-conn-plugin branch January 22, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: conduit connector-plugins describe PLUGIN
2 participants