GitHub workflows, Makefile, etc. #2
Conversation
.github/workflows/release.yml
Outdated
| @@ -0,0 +1,33 @@ | |||
| name: release | |||
There was a problem hiding this comment.
There's no binary to release though, it's just a library, I think we can remove this action.
| - gosec | ||
| - revive | ||
|
|
||
| linters: |
There was a problem hiding this comment.
The linter config was probably taken from the conduit project, right? I suggest rather taking it from a newer project like conduit-commons since it has a stricter config.
go.mod
Outdated
| @@ -4,5 +4,192 @@ go 1.23.0 | |||
|
|
|||
| require ( | |||
| github.com/Masterminds/semver/v3 v3.3.0 | |||
| github.com/conduitio/evolviconf/evolviyaml v0.0.0-20241105144803-b3ba81765197 | |||
There was a problem hiding this comment.
We should avoid this dependency, evolviconf should be able to stand by itself, evolviyaml wraps it and adds support for yaml configs. There could be other formats like toml or json. I propose creating a separate go module for examples, so that this module stays clean (e.g. github.com/conduitio/evolviconf/examples).
README.md
Outdated
| file, log warnings about unknown fields, fall back to a version, etc. | ||
|
|
||
| EvolviConf supports |
There was a problem hiding this comment.
So cool, didn't know it supports! 😄
There was a problem hiding this comment.
Darn it, looks like I lost the readme changes I had.:/
Closes #1.