This repository has been archived by the owner on Jan 3, 2019. It is now read-only.
Adding http_cache parameter to @viewconfig functions #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any suggestions on how write a unit test to check the functionally of these changes? I'm at a loss. |
|
Also does there need to be a http_cache = NO_CACHE parameter added here? cnx-authoring/cnxauthoring/views.py Line 75 in 1847d78 I guess not... |
|
Please rebase this. Also, can you confirm the headers through the browsers dev console and paste them here? |
…ue equal to zero
rich-hart
force-pushed
the
no_caching_for_authenticated_views
branch
from
1847d78 to
365cfe1
Compare
|
Changes Unknown when pulling 365cfe1 on no_caching_for_authenticated_views into * on master*. |
|
@rich-hart Did you mean to close this? |
|
@pumazi I did, about to reopen another one |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"When you supply an http_cache value to a view configuration, the Expires and Cache-Control headers of a response generated by the associated view callable are modified. The value for http_cache may be ... zero (0). If the value is zero, the Cache-Control and Expires headers present in all responses from this view will be composed such that client browser cache (and any intermediate caches) are instructed to never cache the response."
- pyramid view configuration documentation
Any @authenticated_only function is set to NO_CACHE by default
Fixes #206