Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align dependencies to make plugins work #951

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Align dependencies to make plugins work #951

merged 1 commit into from
Jan 24, 2025

Conversation

mapachurro
Copy link
Collaborator

This PR:

  • Brings the npm version to an opinionated 20, hopefully will avoid gremlins in different parts of the build / deploy pipeline, and plays nicely with Vercel
  • Explicitly adds a couple of deps that should be automatically pulled in, but it's not clear that they are.

cc @jlwllmr : If this passes all checks / Vercel, I'm going to go ahead and ship, to try and make progress on this. 🙏

Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-zk-evm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 2:47pm

@mapachurro
Copy link
Collaborator Author

Green across the board. I'm going to merge this, and hopefully we get some things fixed.
image

@mapachurro mapachurro merged commit 9f9ae81 into main Jan 24, 2025
9 checks passed
@mapachurro mapachurro deleted the gtm-mk-2 branch January 24, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant