Weak subjectivity checkpoint accepts a URL. #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igners. Signed-off-by: Byron Gravenorst <[email protected]>
Signed-off-by: Byron Gravenorst <[email protected]>
Signed-off-by: Byron Gravenorst <[email protected]>
Signed-off-by: Byron Gravenorst <[email protected]>
…to bgravenorst-TEKU-194
Signed-off-by: bgravenorst <[email protected]>
mbaxter
approved these changes
Apr 29, 2021
docs/Reference/CLI/CLI-Syntax.md
Outdated
| @@ -1867,7 +1867,13 @@ When `LOGGING` is enabled, attestation and block performance is reported as log | |||
| ws-checkpoint: "0x5a642bb8f367e98c0d11426d98d28c465f8988fc960500886cb49faf0372883a:3600" | |||
| ``` | |||
|
|
|||
| A recent checkpoint within the [weak subjectivity period]. | |||
| A recent checkpoint within the [weak subjectivity period]. Accepts the checkpoint using either | |||
| `<blockRoot>:<epochNumber>`, or a URL containing the `<blockRoot>:<epochNumber>` in a JSON payload. | |||
There was a problem hiding this comment.
Might be helpful to describe the expected payload structure? Or just paste an example of the json.
Suggested change
| `<blockRoot>:<epochNumber>`, or a URL containing the `<blockRoot>:<epochNumber>` in a JSON payload. | |
| `<blockRoot>:<epochNumber>`, or a URL which returns the `<blockRoot>:<epochNumber>` in a JSON payload via the key `ws_checkpoint`. |
Also may be worth highlighting that the literal value (root:epoch) needs to start with "0x"
Signed-off-by: bgravenorst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Weak subjectivity checkpoint accepts a URL.
Fixed Issue(s)
Fixes #267