Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove private endpoint from run teku example #284

Merged
merged 2 commits into from
May 6, 2021
Merged

remove private endpoint from run teku example #284

merged 2 commits into from
May 6, 2021

Conversation

alexandratran
Copy link
Contributor

Pull Request Description

Remove private endpoint from Run Teku example.

Fixed Issue(s)

fixes #280

@alexandratran alexandratran requested review from a team May 5, 2021 22:51
ajsutton
ajsutton approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current version works and is better than having a secret key in the docs but might be worth considering still having multiple endpoints specified.

bgravenorst
bgravenorst approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandratran alexandratran merged commit 895d5b1 into Consensys:master May 6, 2021
@alexandratran alexandratran deleted the 280_update_start_teku_example branch May 6, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgravenorst bgravenorst bgravenorst approved these changes

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Examples should not include private endpoints
3 participants
@alexandratran @ajsutton @bgravenorst