Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds infura information to initial-state #286

Merged
merged 4 commits into from
May 24, 2021

Conversation

cooganb
Copy link
Contributor

@cooganb cooganb commented May 7, 2021

Pull Request Description

Hi there! This adds the information about Infura's ETH2 offering of an initial state to its users.

Fixed Issue(s)

@CLAassistant
Copy link

CLAassistant commented May 7, 2021

CLA assistant check
All committers have signed the CLA.

@cooganb cooganb changed the title adds infura information to intial-state adds infura information to initial-state May 7, 2021
Copy link
Member

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a suggestion to simplify the sentences and make the link more SEO compliant. Plus using the right sharing format for Youtube link.

docs/HowTo/Get-Started/Checkpoint-Start.md Outdated Show resolved Hide resolved
@cooganb
Copy link
Contributor Author

cooganb commented May 11, 2021

@NicolasMassart Sounds good! I believe I merged your suggestion

Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -37,6 +37,9 @@ on the beacon chain client (for example Teku).
```bash
curl -o state.ssz -H 'Accept: application/octet-stream' http://other-node:5051/eth/v1/debug/beacon/states/finalized
```
[Infura](https://infura.io/) provides initial state endpoints for free.
Registration to Infura services is required.
Watch the ("Teku Snapshot Sync from Infura" video)[https://youtu.be/ce9uVRl23zI] for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually as per other discussions:

Suggested change
Watch the ("Teku Snapshot Sync from Infura" video)[https://youtu.be/ce9uVRl23zI] for more details.
Watch the ("Teku Checkpoint Sync from Infura" video)[https://youtu.be/ce9uVRl23zI] for more details.

@ConsenSys-Academy
Copy link

Wanted to see what the status of merging this is? @ajsutton 's changes are good for me

@ConsenSys-Academy
Copy link

Also, we may want to change the title of the doc to reflect the consistent terminology, "Checkpoint Sync"

Copy link
Member

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@NicolasMassart NicolasMassart merged commit cd48892 into Consensys:master May 24, 2021
@cooganb cooganb deleted the patch-1 branch May 24, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants