Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slashing protection repair cli (#295) #304

Merged
merged 9 commits into from
Sep 2, 2021
Merged

Add slashing protection repair cli (#295) #304

merged 9 commits into from
Sep 2, 2021

Conversation

rolandtyler
Copy link
Contributor

@rolandtyler rolandtyler commented Aug 30, 2021 •
edited
Loading

Pull request checklist

Use the following list to make sure your PR fits the Teku doc quality standard.

Before creating the pull request

Make sure that:

After creating your pull request and tests finished

Make sure that:

  • you have fixed all the issues raised by the tests, if any.
  • you have verified the rendering of your changes on
    ReadTheDocs.org PR preview
    and updated the testing link (see Testing).

Describe the change

Adding the slashing-protection repair subcommand and options. Updated formatting on subcommands to match style guides and provide consistency.

Issue fixed

Fixes #295

Impacted parts

For content changes

  • Doc content
  • Doc pages organisation

For tools changes

  • CircleCI workflow
  • Build and QA tools (lint, vale,…)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • ReadTheDocs configuration
  • GitHub integration

Testing

Screenshots / recording

@rolandtyler rolandtyler requested review from rolfyone and a team August 30, 2021 19:16
@alexandratran alexandratran requested a review from rolfyone August 31, 2021 18:00
@rolandtyler rolandtyler requested a review from rolfyone August 31, 2021 21:14
@rolandtyler rolandtyler requested a review from rolfyone September 1, 2021 14:55
rolfyone
rolfyone approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alexandratran
alexandratran approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise LGTM.

docs/Reference/CLI/Subcommands/Slashing-Protection.md Outdated Show resolved Hide resolved
docs/Reference/CLI/Subcommands/Slashing-Protection.md Outdated Show resolved Hide resolved
docs/Reference/CLI/Subcommands/Slashing-Protection.md Outdated Show resolved Hide resolved
docs/Reference/CLI/Subcommands/Slashing-Protection.md Show resolved Hide resolved
alexandratran
alexandratran approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for all the extra work!

@rolandtyler rolandtyler merged commit 720d21f into Consensys:master Sep 2, 2021
@rolandtyler rolandtyler deleted the add-slashing-protection-repair-CLI-(#295) branch September 2, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfyone rolfyone rolfyone approved these changes

@alexandratran alexandratran alexandratran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document slashing protection repair CLI command
3 participants
@rolandtyler @rolfyone @alexandratran