Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on pyethereum to improve cross platform support and reduce installation size #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ferret-guy
Copy link

Pull in utils and abi from pyethereum in order to allow installation on a wider array of devices fixing the following issues:
#19
#5

@maurycyp
Copy link
Contributor

maurycyp commented Feb 1, 2017

@ferret-guy Mark, are there any licensing issues we should be concerned about with regard to cutting and pasting this code?

@ferret-guy
Copy link
Author

The source code is MIT licensed, I have already added the appropriate license headers to the files, but that means that this code conflicts with the unlicense, and would require derivative work to include attribution for thease files.

@maurycyp
Copy link
Contributor

maurycyp commented Feb 1, 2017

I chose the Unlicense to avoid thinking about these issues. I suppose I could re-license--BSD or MIT may be better.

@ferret-guy
Copy link
Author

It seems that most ethereum projects that are MIT, that would mean that in the future if more code needed to be pulled in then, it wouldn't be Unlicense* (except for thease specific files). The other option might be branching pyethereum with a branch for just the utility functions, but that would essentially mean maintaining two parallel packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants