parse args and validate before any setup

Signed-off-by: Sally MacFarlane <[email protected]>
Consensys · Feb 17, 2020 · de702f2 · usmansaleem · Feb 17, 2020 · usmansaleem
1 parent 09bdbd0
commit de702f2
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/ethsigner/commandline/src/main/java/tech/pegasys/ethsigner/CommandlineParser.java b/ethsigner/commandline/src/main/java/tech/pegasys/ethsigner/CommandlineParser.java
@@ -59,8 +59,10 @@ public boolean parseCommandLine(final String... args) {
     }
 
     try {
-      commandLine.parseWithHandlers(new RunLast().useOut(output), new ExceptionHandler<>(), args);
+      // parseArgs ensures all args are populated and can then be validated prior to any setup
+      commandLine.parseArgs(args);
       baseCommand.validateOptions(commandLine, LOG);
+      commandLine.parseWithHandlers(new RunLast().useOut(output), new ExceptionHandler<>(), args);
       return true;
     } catch (final ParameterException ex) {
       handleParameterException(ex);