Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: readme #592

Merged
merged 2 commits into from
Jan 20, 2025
Merged

docs: readme #592

merged 2 commits into from
Jan 20, 2025

Conversation

Olexandr88
Copy link
Contributor

@Olexandr88 Olexandr88 commented Jan 2, 2025

Not all links were working, after adjustment everything works fine

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Note that in most cases the PR should be against the develop branch.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran or implemented to verify your changes. Provide instructions so we can reproduce.

  • Test A
  • Test B

How has this been benchmarked?

Please describe the benchmarks that you ran to verify your changes.

  • Benchmark A, on Macbook pro M1, 32GB RAM
  • Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Not all links were working, after adjustment everything works fine
@gbotrel gbotrel added the typo Typo fixes label Jan 14, 2025
@ivokub ivokub changed the base branch from master to fix/typos-v0.15 January 20, 2025 23:33
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission

@ivokub ivokub merged commit 35a8364 into Consensys:fix/typos-v0.15 Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typo Typo fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants