Merge pull request #160 from ConsenSys/perf-unsafe-decoding

feat: added UnsafeReadFrom for groth16 Proving and Verifying keys
Consensys · Oct 29, 2021 · 71df9c6 · 71df9c6
2 parents d9de872 + 7a6abbe
commit 71df9c6
Show file tree

Hide file tree

Showing 15 changed files with 456 additions and 544 deletions.
diff --git a/backend/groth16/groth16.go b/backend/groth16/groth16.go
@@ -68,6 +68,7 @@ type Proof interface {
 // it's underlying implementation is strongly typed with the curve (see gnark/internal/backend)
 type ProvingKey interface {
 	groth16Object
+	gnarkio.UnsafeReaderFrom
 
 	// NbG1 returns the number of G1 elements in the ProvingKey
 	NbG1() int
@@ -85,6 +86,7 @@ type ProvingKey interface {
 // ExportSolidity is implemented for BN254 and will return an error with other curves
 type VerifyingKey interface {
 	groth16Object
+	gnarkio.UnsafeReaderFrom
 
 	// NbPublicWitness returns number of elements expected in the public witness
 	NbPublicWitness() int

diff --git a/internal/backend/bls12-377/groth16/groth16_test.go b/internal/backend/bls12-377/groth16/groth16_test.go
diff --git a/internal/backend/bls12-377/groth16/marshal.go b/internal/backend/bls12-377/groth16/marshal.go