-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added HashToG2 and BLS G2 signature verification circuit for BLS12-381 #1024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keep seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
weijiguo
changed the title
implementation HashToG2 for bls12-381
feat: added HashToG2 circuit for BLS12-381
Jan 28, 2024
revised G2.addUnified function based on the Brier and Joye algorithm
fixed G2.sgn0 function and associated unit tests for BLS12-381
weijiguo
changed the title
feat: added HashToG2 circuit for BLS12-381
feat: added HashToG2 and BLS G2 signature verification circuit for BLS12-381
Jan 29, 2024
The source branch has been pushed some unwanted commits. I am closing this one and opening a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implemented circuit for
HashToG2
and BLS G2 signature verification for the BLS12-381 curve. The implementation is based on affine coordinations.Along with the said functionalities, it also added
G2.addUnified(p, q)
function which can handle the case thatp == q
. And as an optimization, it also adopted a new hint to calculate thesqrtRatio
function with the gnark-crypto library to save constraints. Therefore this PR depends on an update to gnark-cryptoFixes # (issue)
#648
Type of change
How has this been tested?
Added unit tests to cover:
How has this been benchmarked?
Added test cases for HashToG2. Results: 2761896 constraints with SCS and 779198 with R1CS for simple message ("abcd").
Checklist:
golangci-lint
does not output errors locally