Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use maps.Clone to simplify the code and reorder packages #1390

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

dashangcun
Copy link
Contributor

@dashangcun dashangcun commented Jan 9, 2025

Description

This is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

  • Test A
  • Test B

How has this been benchmarked?

  • Benchmark A, on Macbook pro M1, 32GB RAM
  • Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gbotrel gbotrel added the typo Fixes typos in comments or documentation label Jan 16, 2025
@ivokub ivokub changed the base branch from master to fix/typos-v0.12 January 21, 2025 12:28
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@ivokub ivokub merged commit fea7f9f into Consensys:fix/typos-v0.12 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typo Fixes typos in comments or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants