Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccs.GetConstraints readable output #244

Merged
merged 9 commits into from
Jan 28, 2022
Merged

ccs.GetConstraints readable output #244

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b476f2f
style: constraint is not satified err -> constraint #id is not satisfied
gbotrel Jan 26, 2022
08eb7a8
style: plonk human readable constraint A+M+k == O
gbotrel Jan 27, 2022
ee9da82
style: experiment 1 plonk constraint string repr
gbotrel Jan 27, 2022
3f93632
style: experiment 2 constraint str
gbotrel Jan 27, 2022
7773406
style: return constraint formatted as in the paper
gbotrel Jan 27, 2022
208e4c7
style: cosmetics in sparseR1C repr
gbotrel Jan 27, 2022
f6b5e86
style: constraint cosmetics string repr. remove ToHTML deadcode
gbotrel Jan 28, 2022
e4be990
style: clean up unsatisfied constraint error paths
gbotrel Jan 28, 2022
68debdd
perf: minimize allocations in ccs.GetConstraints
gbotrel Jan 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions debug_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,15 @@ func TestTraceDivBy0(t *testing.T) {
{
_, err := getGroth16Trace(&circuit, &witness)
assert.Error(err)
assert.Contains(err.Error(), "constraint is not satisfied: [div] 2/(-2 + 2) == <unsolved>")
assert.Contains(err.Error(), "constraint #0 is not satisfied: [div] 2/(-2 + 2) == <unsolved>")
assert.Contains(err.Error(), "(*divBy0Trace).Define")
assert.Contains(err.Error(), "debug_test.go:")
}

{
_, err := getPlonkTrace(&circuit, &witness)
assert.Error(err)
assert.Contains(err.Error(), "constraint is not satisfied: [inverse] 1/0 < ∞")
assert.Contains(err.Error(), "constraint #1 is not satisfied: [inverse] 1/0 < ∞")
assert.Contains(err.Error(), "(*divBy0Trace).Define")
assert.Contains(err.Error(), "debug_test.go:")
}
Expand Down Expand Up @@ -120,15 +120,15 @@ func TestTraceNotEqual(t *testing.T) {
{
_, err := getGroth16Trace(&circuit, &witness)
assert.Error(err)
assert.Contains(err.Error(), "constraint is not satisfied: [assertIsEqual] 1 == (24 + 42)")
assert.Contains(err.Error(), "constraint #0 is not satisfied: [assertIsEqual] 1 == (24 + 42)")
assert.Contains(err.Error(), "(*notEqualTrace).Define")
assert.Contains(err.Error(), "debug_test.go:")
}

{
_, err := getPlonkTrace(&circuit, &witness)
assert.Error(err)
assert.Contains(err.Error(), "constraint is not satisfied: [assertIsEqual] 1 + -66 == 0")
assert.Contains(err.Error(), "constraint #1 is not satisfied: [assertIsEqual] 1 + -66 == 0")
assert.Contains(err.Error(), "(*notEqualTrace).Define")
assert.Contains(err.Error(), "debug_test.go:")
}
Expand Down Expand Up @@ -157,15 +157,15 @@ func TestTraceNotBoolean(t *testing.T) {
{
_, err := getGroth16Trace(&circuit, &witness)
assert.Error(err)
assert.Contains(err.Error(), "constraint is not satisfied: [assertIsBoolean] (24 + 42) == (0|1)")
assert.Contains(err.Error(), "constraint #0 is not satisfied: [assertIsBoolean] (24 + 42) == (0|1)")
assert.Contains(err.Error(), "(*notBooleanTrace).Define")
assert.Contains(err.Error(), "debug_test.go:")
}

{
_, err := getPlonkTrace(&circuit, &witness)
assert.Error(err)
assert.Contains(err.Error(), "constraint is not satisfied: [assertIsBoolean] 66 == (0|1)")
assert.Contains(err.Error(), "constraint #1 is not satisfied: [assertIsBoolean] 66 == (0|1)")
assert.Contains(err.Error(), "(*notBooleanTrace).Define")
assert.Contains(err.Error(), "debug_test.go:")
}
Expand Down
3 changes: 0 additions & 3 deletions frontend/ccs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@ type CompiledConstraintSystem interface {
CurveID() ecc.ID
FrSize() int

// ToHTML generates a human readable representation of the constraint system
ToHTML(w io.Writer) error

// GetCounters return the collected constraint counters, if any
GetCounters() []compiled.Counter

Expand Down
86 changes: 5 additions & 81 deletions internal/backend/bls12-377/cs/r1cs.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

133 changes: 73 additions & 60 deletions internal/backend/bls12-377/cs/r1cs_sparse.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions internal/backend/bls12-377/cs/solution.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading