Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low gas stipend precompile calls #1754

Merged
merged 52 commits into from
Feb 20, 2025
Merged

Low gas stipend precompile calls #1754

merged 52 commits into from
Feb 20, 2025
+521 −28

Conversation

lorenzogentile404
Copy link
Collaborator

No description provided.

@lorenzogentile404 lorenzogentile404 linked an issue Jan 30, 2025 that may be closed by this pull request
Low gas stipend precompile calls #1730
Closed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

OlivierBBB
OlivierBBB requested changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@OlivierBBB OlivierBBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More parametric and if necessary pre-populate memory to simplify computations.

OlivierBBB
OlivierBBB requested changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@OlivierBBB OlivierBBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several changes are in place. Otherwise looks good to me.

OlivierBBB
OlivierBBB reviewed Feb 19, 2025
View reviewed changes
arithmetization/src/main/java/net/consensys/linea/zktracer/module/oob/OobOperation.java
} else if (ebs > 32 && leadingBytesOfExponent.signum() != 0) {
return 8 * (ebs - 32) + log2(leadingBytesOfExponent, RoundingMode.FLOOR);
} else {
return 8 * (ebs - 32);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reading this makes me wonder whether we have tests where we deliberately set the leadingBytesOfExponent to zero ...

@OlivierBBB OlivierBBB mentioned this pull request Feb 19, 2025
Open
OlivierBBB
OlivierBBB approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@OlivierBBB OlivierBBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OlivierBBB OlivierBBB enabled auto-merge (squash) February 19, 2025 23:58
@OlivierBBB OlivierBBB merged commit 74238c0 into arith-dev Feb 20, 2025
6 checks passed
@OlivierBBB OlivierBBB deleted the 1730-low-gas-stipend-precompile-calls branch February 20, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierBBB OlivierBBB OlivierBBB approved these changes

@amkCha amkCha Awaiting requested review from amkCha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Low gas stipend precompile calls
2 participants
@lorenzogentile404 @OlivierBBB