fix: Fix issues in binary_search.sh #1763
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update improves the JSON generation process by using
jq
, ensuring proper handling of quotes and spaces.I've also fixed the issue with
mid
rounding, where it now correctly rounds up, preventing infinite recursion.Additionally, checks have been added before recursion to ensure that we don't repeatedly call the same range:
if [ "$mid" -gt "$start" ]
andif [ "$mid" -lt "$end" ]
.This should prevent unnecessary loops and improve performance.