Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardise the Engine Json RPC error codes #8671

Closed
mehdi-aouadi opened this issue Oct 2, 2024 · 3 comments · Fixed by #8695
Closed

Standardise the Engine Json RPC error codes #8671

mehdi-aouadi opened this issue Oct 2, 2024 · 3 comments · Fixed by #8695
Labels
enhancement 🕵️‍♀️ New feature or request good first issue 🙋 This is a good first issue for a new contributor to work on

Comments

@mehdi-aouadi
Copy link
Contributor

mehdi-aouadi commented Oct 2, 2024 •
edited
Loading

The json RPC error codes are standard: JSON-RPC 2.0 Specification
It would be better to handle the errors in the Web3JClient::doRequest based on their codes and avoid logging the whole stack trace.
Example: error code -32601 -> Method not found
@mehdi-aouadi mehdi-aouadi added the enhancement 🕵️‍♀️ New feature or request label Oct 2, 2024
@Malaydewangan09
Copy link
Contributor

Hey @mehdi-aouadi , is this issue still open?
Can I start working on it?
Thanks!

@tbenr tbenr added the good first issue 🙋 This is a good first issue for a new contributor to work on label Oct 8, 2024
@mehdi-aouadi
Copy link
Contributor Author

Hi @Malaydewangan09, yes it's open. Feel free to raise a PR and don't hesitate to reach out to our discord contributors channel if you have any question

@Malaydewangan09
Copy link
Contributor

@mehdi-aouadi
Thanks!

This was referenced Oct 9, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🕵️‍♀️ New feature or request good first issue 🙋 This is a good first issue for a new contributor to work on
Projects
None yet
Milestone
No milestone
3 participants
@mehdi-aouadi @tbenr @Malaydewangan09