Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardise the Engine JSON-RPC error codes #8694

Closed
wants to merge 2 commits into from
Closed

Standardise the Engine JSON-RPC error codes #8694

wants to merge 2 commits into from

Conversation

Malaydewangan09
Copy link
Contributor

@Malaydewangan09 Malaydewangan09 commented Oct 9, 2024 •
edited
Loading

PR Description

This pull request standardises the handling of JSON-RPC error codes in the Web3JClient::doRequest method according to the JSON-RPC 2.0 specification. It introduces specific error code handling for well-known JSON-RPC errors and customizes error messages to reduce unnecessary stack trace logging.

Fixed Issue(s)

Resolves #8671

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Malaydewangan09 Malaydewangan09 mentioned this pull request Oct 9, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardise the Engine Json RPC error codes
2 participants
@Malaydewangan09 @CLAassistant