Move electra attestation's committeeBits at the end #8344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbenr
changed the title
tbenr
changed the title
|
requires reference test update too |
|
we won't be able to merge this until the spec reftests are updated, but overall looks fine, as long as the spec is changing it. |
rolfyone
approved these changes
May 30, 2024
|
The spec PR has been merged. We just need to wait for ref-test release (ethereum/consensus-specs#3786) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8340
We could wait the spec PR to be merged, just to avoid early compatibility breaks with other clients
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog