Added Consolidation Request containers #8392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucassaldanha
force-pushed
the
consolidation-containers
branch
from
c06d146 to
ca2a4f3
Compare
rolfyone
reviewed
Jun 21, 2024
Comment on lines
+6
to
+11
| "source_address" : { | ||
| "type" : "string", | ||
| "pattern" : "^0x[a-fA-F0-9]{2,}$", | ||
| "description" : "SSZ hexadecimal", | ||
| "format" : "bytes" | ||
| }, |
There was a problem hiding this comment.
spec says ExecutionAddress is bytes20, can we fix description?
There was a problem hiding this comment.
Sure. I'll fix it on ExecutionLayerWithdrawalRequest as well =)
There was a problem hiding this comment.
I think I'll need to look into this as a separate thing because Eth1Address type is mapping to SSZ hexadecimal on the expected description. I won't try to fix it in this PR because it is already big enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
(this PR builds on top of #8391, it will be easier if we get that merged first)
Fixed Issue(s)
related to #8377