Updated process_consolidation_requests #8400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated ref tests linking
gfukushima
approved these changes
Jun 25, 2024
| private void processConsolidationRequest( | ||
| final MutableBeaconStateElectra state, final ConsolidationRequest consolidationRequest) { | ||
| final UInt64 slot = state.getSlot(); | ||
| final UInt64 currentEpoch = miscHelpers.computeEpochAtSlot(slot); |
There was a problem hiding this comment.
Maybe we could move this line further below, right before where the currentEpoch gets used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
process_consolidationtoprocess_consolidation_requests(and some other naming alignment)The most important change in this PR is on:
BlockProcessorElectra#processConsolidationRequests.Reference to spec method: https://github.com/ethereum/consensus-specs/blob/dev/specs/electra/beacon-chain.md#new-process_consolidation_request
Fixed Issue(s)
relates to #8377
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog