change StateSelector logic #8985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes Consensys#7955 needs more testing, need to see how AT goes initially. Signed-off-by: Paul Harris <[email protected]>
|
also moved some private functions to the bottom (breaks my own rule of not refactoring). The new functionality was a finalized selector similar to teh justified flow in CombinedChainDataClient, and a |
rolfyone
commented
Jan 13, 2025
Comment on lines
-90
to
-92
| // The finalized checkpoint may change because of optimistically | ||
| // imported blocks at the head and if the head isn't optimistic, the | ||
| // finalized block can't be optimistic. |
There was a problem hiding this comment.
there was nothing testing this.
i went with the on_block implementation of the finalized state where we base it off of the checkpoint.
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
…g but useful. Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7955
alternative solution to #8782
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog