Assert DB is open before createStreamKeyRaw #9014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
storage/src/main/java/tech/pegasys/teku/storage/server/rocksdb/RocksDbInstance.java
Fixed
Show fixed
Hide fixed
storage/src/main/java/tech/pegasys/teku/storage/server/rocksdb/RocksDbInstance.java
Fixed
Show fixed
Hide fixed
gfukushima
force-pushed
the
rocksdb-sigsevv-fix
branch
from
883f7b2 to
b12d493
Compare
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
rolfyone
reviewed
Jan 27, 2025
| @@ -160,6 +165,7 @@ public Stream<ColumnEntry<Bytes, Bytes>> streamRaw(final KvStoreColumn<?, ?> col | |||
| @Override | |||
| @MustBeClosed | |||
| public Stream<Bytes> streamKeysRaw(final KvStoreColumn<?, ?> column) { | |||
| assertOpen(); | |||
There was a problem hiding this comment.
this is checked in createStreamRaw, we can let it go through here i think...
rolfyone
reviewed
Jan 27, 2025
| @@ -60,6 +64,7 @@ public class RocksDbInstance implements KvStoreAccessor { | |||
|
|
|||
| @Override | |||
| public <T> Optional<T> get(final KvStoreVariable<T> variable) { | |||
| assertOpen(); | |||
There was a problem hiding this comment.
this one shouldnt be needed? it's asserted in getRaw...
tbenr
reviewed
Jan 28, 2025
services/chainstorage/src/main/java/tech/pegasys/teku/services/chainstorage/StorageService.java
Show resolved
Hide resolved
|
closing this as a few improvements here were merged on other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds a validation before create a stream to avoid the SIGSEGV we were getting on shutdown using RocksDB.
Fixed Issue(s)
Fixes #8939
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog