Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Financial NPV Metric #588

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

gkahiu
Copy link
Collaborator

@gkahiu gkahiu commented Dec 12, 2024

Adds a metric for calculating an activity's NPV.

This PR provides an implementation for #575.

@gkahiu gkahiu added this to the Phase 3 milestone Dec 12, 2024
@gkahiu gkahiu requested a review from Samweli December 12, 2024 11:33
Copy link
Contributor

github-actions bot commented Dec 12, 2024

badge

Plugin zip package for the changes in this PR has been successfully built!.

Download the plugin zip file here https://github.com/ConservationInternational/cplus-plugin/suites/32174716363/artifacts/2333107567

@amyburness
Copy link
Collaborator

@gkahiu test
library looks good
image
image
image
error
image

@gkahiu
Copy link
Collaborator Author

gkahiu commented Dec 12, 2024

Thanks @amyburness , similar to the PWL impact. Could you remove the 'NPV' column and check if you can get the area calculation?

@amyburness
Copy link
Collaborator

@gkahiu I tried it in a clean version of QGIS with 2 NCS pathways. 1 PWL (the NPV) and then added to NPV to the metric generator and it worked as expected.
image

image

# Conflicts:
#	src/cplus_plugin/definitions/defaults.py
#	src/cplus_plugin/lib/reports/metrics.py
#	test/test_metrics.py
@Samweli Samweli merged commit 7b9f219 into ConservationInternational:main Dec 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants