Improve detection of empty figma components #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradmering
changed the title
ghost
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates default tokens in the sass/projects folder and includes them both in the sass/main.scss for the project, the templates/main.scss for the previews, and in the installer/template/templates/main.scss so they get included with new builds for the templates.
This will solve both the fetch problem where we can't build templates if the tokens cannot be found, plus it solves the static build where the templates cannot be found.
It introduces a new prop for the component pages called
componentFound: boolean;that allows us to return a not found page. ThecomponentNotFoundcomponent accepts the arguments for a normal page, and renders a not found page with the metadata for a normal page. We can customize that component as needed.This PR also filters the menu, so if a component is in the menu, but no components are found from figma, it won't show even if the menu says it should. This will make the default menu behavior more sane.