Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.16.3 introduced "node": ">=10" depencency #160

Closed
metalass opened this issue Apr 2, 2020 · 5 comments
Closed

v1.16.3 introduced "node": ">=10" depencency #160

metalass opened this issue Apr 2, 2020 · 5 comments

Comments

@metalass
Copy link

metalass commented Apr 2, 2020

In v1.16.3 packages were bumped, in particular semver from 6.3.0 to 7.1.3. In this new version of semver new dependency was introduced:

https://github.com/npm/node-semver/blob/master/package.json#L36

I'm not sure if this could be considered as breaking change but productions servers with lower node version harmed.

@ljharb
Copy link
Contributor

ljharb commented Apr 2, 2020

Indeed, semver should be pinned at v6; this is a breaking change.

@cookpete
Copy link
Owner

cookpete commented Apr 2, 2020

Yep I overlooked this when using the sledgehammer of yarn upgrade --latest. Apologies to anyone this affects. I plan to release v1.16.4 with semver pinned and then deprecate v1.16.3. Then maybe bump semver and drop node 8 support in v2.0.0.

@ljharb
Copy link
Contributor

ljharb commented Apr 2, 2020

There’s no value in bumping semver or dropping support for older nodes; why rush to a v2?

@cookpete
Copy link
Owner

cookpete commented Apr 2, 2020

I think there’s value in keeping up with the latest versions of dependencies, if we assume later versions are generally better, faster and/or more secure. It also avoids your dependency tree from stagnating over time.

There's no rush to v2, but it is happening soon (whenever I get time), so seems like a convenient time for ending support for Node 8. It reached end of life in December 2019 anyway, and probably means I can get rid of a bunch of the core-js polyfill stuff while I'm at it.

@cookpete
Copy link
Owner

cookpete commented Apr 2, 2020

I plan to release v1.16.4 with semver pinned and then deprecate v1.16.3.

This is now done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants