update package url and add example #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CoolProp/CoolProp.jl` is now ahead of the original. Removed `nightly` as it is 5 years old. Simplified installation, tested with `julia-1.6.1`.
|
@barche this all looks good to me, do you have any feedback? |
|
Looks good to me! |
duncanam
approved these changes
Jan 9, 2022
|
@barche looks like I don't have write access- are you able to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for creating this wrapper, it works nicely.
This PR a new take at #9, since
Pkg.clonehas been removed(could not determine when from julia or Pkg changelogs).
It should fix #12 and #10.
Installation is simplified and smooth, tested with
julia-1.6.1.CoolProp/CoolProp.jlis now ahead of the original.Removed
nightlyas it is 5 years old.And added an example and a link to the API.