Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also add url to sample config & fix schema #33

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

alinetskyi
Copy link
Collaborator

@alinetskyi alinetskyi commented Nov 7, 2023

This change is Reviewable

@alinetskyi alinetskyi self-assigned this Nov 7, 2023
@alinetskyi alinetskyi requested a review from a team as a code owner November 7, 2023 09:21
@alinetskyi alinetskyi requested review from dzmitryhil, miladz68, ysv and keyleu and removed request for a team November 7, 2023 09:21
Copy link

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alinetskyi, @keyleu, @miladz68, and @ysv)


config-sample.yaml line 43 at r1 (raw file):

database:
    url: postgresql://root:password@postgres:5432/root?sslmode=disable&search_path=public
    name: root # This is the defaults, but might be updated

Why do need other args you use the URL ?

Copy link
Collaborator Author

@alinetskyi alinetskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @keyleu, @miladz68, and @ysv)


config-sample.yaml line 43 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Why do need other args you use the URL ?

this will allow to support both versions of bdjuno new and old

@alinetskyi alinetskyi changed the title Also add url to sample config Also add url to sample config & fix schema Nov 7, 2023
@ysv ysv requested a review from dzmitryhil November 7, 2023 11:55
Copy link

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alinetskyi, @dzmitryhil, @keyleu, and @miladz68)


database/schema/02-bank.sql line 11 at r2 (raw file):

);
CREATE INDEX staking_params_height_index ON staking_params (height);

it is a bad idea to modify existing migration

Copy link
Collaborator Author

@alinetskyi alinetskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @keyleu, @miladz68, and @ysv)


database/schema/02-bank.sql line 11 at r2 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

it is a bad idea to modify existing migration

Well, it was modified in wojtek's PR, I just revert it back here to how it's supposed to be

@dzmitryhil dzmitryhil requested a review from ysv November 7, 2023 12:59
Copy link

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @keyleu, @miladz68, and @ysv)

Copy link

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @keyleu, @miladz68, and @ysv)

Copy link

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @keyleu and @miladz68)

@alinetskyi alinetskyi merged commit 7344c58 into chains/coreum Nov 7, 2023
1 of 2 checks passed
@alinetskyi alinetskyi deleted the fix_database_config_and_schema branch November 7, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants