-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also add url to sample config & fix schema #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alinetskyi, @keyleu, @miladz68, and @ysv)
config-sample.yaml
line 43 at r1 (raw file):
database: url: postgresql://root:password@postgres:5432/root?sslmode=disable&search_path=public name: root # This is the defaults, but might be updated
Why do need other args you use the URL ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @keyleu, @miladz68, and @ysv)
config-sample.yaml
line 43 at r1 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
Why do need other args you use the URL ?
this will allow to support both versions of bdjuno new and old
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alinetskyi, @dzmitryhil, @keyleu, and @miladz68)
database/schema/02-bank.sql
line 11 at r2 (raw file):
); CREATE INDEX staking_params_height_index ON staking_params (height);
it is a bad idea to modify existing migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @keyleu, @miladz68, and @ysv)
database/schema/02-bank.sql
line 11 at r2 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
it is a bad idea to modify existing migration
Well, it was modified in wojtek's PR, I just revert it back here to how it's supposed to be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @keyleu, @miladz68, and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @keyleu, @miladz68, and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @keyleu and @miladz68)
This change is