Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipient to related accounts #38

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

wojtek-coreum
Copy link

@wojtek-coreum wojtek-coreum commented Nov 15, 2023

This change is Reviewable

@wojtek-coreum wojtek-coreum requested a review from a team as a code owner November 15, 2023 11:09
@wojtek-coreum wojtek-coreum requested review from dzmitryhil, miladz68, ysv and keyleu and removed request for a team November 15, 2023 11:09
Copy link

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @keyleu, @miladz68, and @wojtek-coreum)


modules/assetft/account_parser.go line 17 at r1 (raw file):

		return []string{msg.Issuer}, nil
	case *assetfttypes.MsgMint:
		return []string{msg.Sender, msg.Recipient}, nil

I don't remember
Do we have empty recipient or it will be equal to issuer by default ?

Will this case be handled properly here ? no duplicates or empty string ?

dzmitryhil
dzmitryhil previously approved these changes Nov 15, 2023
Copy link

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @keyleu, @miladz68, and @wojtek-coreum)

Copy link
Author

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @keyleu, @miladz68, and @ysv)


modules/assetft/account_parser.go line 17 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

I don't remember
Do we have empty recipient or it will be equal to issuer by default ?

Will this case be handled properly here ? no duplicates or empty string ?

oh, you are right. It might be empty. Fixed.

Copy link

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @keyleu and @miladz68)

Copy link

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @keyleu)

@wojtek-coreum wojtek-coreum merged commit f7a6dcb into chains/coreum Nov 16, 2023
2 checks passed
@wojtek-coreum wojtek-coreum deleted the wojtek/recipient branch November 16, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants