Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add x/gov module proposal status change from deposit to voting #42

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix: add x/gov module proposal status change from deposit to voting #42

merged 1 commit into from
Dec 5, 2023

Conversation

dzmitryhil
Copy link

@dzmitryhil dzmitryhil commented Dec 4, 2023 •
edited by CoreumDevelopment
Loading

This change is Reviewable

@dzmitryhil dzmitryhil requested a review from a team as a code owner December 4, 2023 11:47
@dzmitryhil dzmitryhil requested review from miladz68, ysv, wojtek-coreum and keyleu and removed request for a team December 4, 2023 11:47
ysv
ysv approved these changes Dec 4, 2023
View reviewed changes
Copy link

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @keyleu, @miladz68, and @wojtek-coreum)

wojtek-coreum
wojtek-coreum approved these changes Dec 5, 2023
View reviewed changes
Copy link

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @keyleu and @miladz68)

@dzmitryhil dzmitryhil merged commit a7f8d2f into chains/coreum Dec 5, 2023
2 checks passed
@dzmitryhil dzmitryhil deleted the dzmitryhil/update-proposal-state-after-deposit branch January 8, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-coreum wojtek-coreum wojtek-coreum approved these changes

@ysv ysv ysv approved these changes

@miladz68 miladz68 Awaiting requested review from miladz68 miladz68 is a code owner automatically assigned from CoreumFoundation/team-backend

@keyleu keyleu Awaiting requested review from keyleu keyleu is a code owner automatically assigned from CoreumFoundation/team-backend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dzmitryhil @ysv @wojtek-coreum