Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update GetHeight function to return 0 when height is not defined in the payload #58

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

akhlopiachyi
Copy link

@akhlopiachyi akhlopiachyi commented Feb 13, 2024

This change is Reviewable

@akhlopiachyi akhlopiachyi requested a review from a team as a code owner February 13, 2024 12:18
@akhlopiachyi akhlopiachyi requested review from dzmitryhil, miladz68, ysv and wojtek-coreum and removed request for a team February 13, 2024 12:18
Copy link

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil, @miladz68, and @ysv)

Copy link

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @ysv)

@akhlopiachyi akhlopiachyi merged commit 4bbf157 into chains/coreum Feb 20, 2024
3 checks passed
@akhlopiachyi akhlopiachyi deleted the fix/get-height branch February 20, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants