Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI workflow #65

Merged
merged 6 commits into from
Apr 29, 2024
Merged

CI workflow #65

merged 6 commits into from
Apr 29, 2024

Conversation

wojtek-coreum
Copy link

@wojtek-coreum wojtek-coreum commented Apr 9, 2024

This change is Reviewable

@wojtek-coreum wojtek-coreum requested a review from a team as a code owner April 9, 2024 10:47
@wojtek-coreum wojtek-coreum requested review from dzmitryhil, miladz68, ysv and keyleu and removed request for a team April 9, 2024 10:47
miladz68
miladz68 previously approved these changes Apr 9, 2024
Copy link

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil, @keyleu, and @ysv)

dzmitryhil
dzmitryhil previously approved these changes Apr 9, 2024
Copy link

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @keyleu and @ysv)

@wojtek-coreum wojtek-coreum dismissed stale reviews from dzmitryhil and miladz68 via cee7319 April 9, 2024 11:19
miladz68
miladz68 previously approved these changes Apr 9, 2024
Copy link

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @keyleu and @ysv)

dzmitryhil
dzmitryhil previously approved these changes Apr 17, 2024
Copy link

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @keyleu and @ysv)

@wojtek-coreum wojtek-coreum dismissed stale reviews from dzmitryhil and miladz68 via 0d07ac6 April 29, 2024 10:37
Copy link

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 6 files at r1, 1 of 2 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @keyleu and @wojtek-coreum)


build/bdjuno/build.go line 45 at r3 (raw file):

		PackagePath:    filepath.Join(repoPath, "cmd", "bdjuno"),
		Flags: []string{
			binaryOutputFlag + "=" + binOutputPath,

I think we rolled back to BinOutput as a standalone attribute
Lets update it here

Copy link
Author

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 5 of 8 files reviewed, 1 unresolved discussion (waiting on @keyleu, @miladz68, and @ysv)


build/bdjuno/build.go line 45 at r3 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

I think we rolled back to BinOutput as a standalone attribute
Lets update it here

Done.

@dzmitryhil dzmitryhil requested review from miladz68 and ysv April 29, 2024 10:57
Copy link

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 5 of 8 files reviewed, 1 unresolved discussion (waiting on @keyleu, @miladz68, and @ysv)

Copy link

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @keyleu and @miladz68)

@wojtek-coreum wojtek-coreum merged commit ed49d38 into chains/coreum Apr 29, 2024
2 checks passed
@wojtek-coreum wojtek-coreum deleted the wojtek/ci branch April 29, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants