Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update periods to update token_price and token_price_history #67

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

akhlopiachyi
Copy link

@akhlopiachyi akhlopiachyi commented May 30, 2024

This change is Reviewable

@akhlopiachyi akhlopiachyi requested a review from a team as a code owner May 30, 2024 13:01
@akhlopiachyi akhlopiachyi requested review from dzmitryhil, miladz68, ysv and wojtek-coreum and removed request for a team May 30, 2024 13:01
Copy link

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi, @dzmitryhil, @miladz68, and @ysv)


modules/pricefeed/handle_periodic_operations.go line 27 at r1 (raw file):

	}

	// Update the historical token prices every 1 hour

update the comment

Copy link

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi, @miladz68, and @ysv)

dzmitryhil
dzmitryhil previously approved these changes Jun 3, 2024
Copy link

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi, @miladz68, and @ysv)

miladz68
miladz68 previously approved these changes Jun 10, 2024
Copy link

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi and @ysv)

@akhlopiachyi akhlopiachyi dismissed stale reviews from miladz68 and dzmitryhil via bc84f1a July 22, 2024 10:31
Copy link

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi, @miladz68, @wojtek-coreum, and @ysv)

Copy link

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @akhlopiachyi, @wojtek-coreum, and @ysv)

Copy link

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissed @wojtek-coreum from a discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)

Copy link

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)

@miladz68 miladz68 dismissed wojtek-coreum’s stale review July 22, 2024 10:41

wojtek left the company

@akhlopiachyi akhlopiachyi merged commit 1de259a into chains/coreum Jul 22, 2024
2 checks passed
@akhlopiachyi akhlopiachyi deleted the fix/update-periods branch July 22, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants