Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build binary on the runner and add to docker image #72

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

alinetskyi
Copy link
Collaborator

@alinetskyi alinetskyi commented Jun 27, 2024

This change is Reviewable

@alinetskyi alinetskyi requested a review from a team as a code owner June 27, 2024 16:22
@alinetskyi alinetskyi requested review from dzmitryhil, miladz68 and ysv and removed request for a team June 27, 2024 16:22
miladz68
miladz68 previously approved these changes Jun 28, 2024
Copy link

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @ysv)

@alinetskyi alinetskyi force-pushed the fix_build branch 2 times, most recently from d791ebf to 4f9e1f0 Compare June 28, 2024 12:32
@alinetskyi alinetskyi changed the title Use bullseye as builder image Build binary on the runner and add to docker image Jun 28, 2024
@alinetskyi alinetskyi requested a review from miladz68 June 28, 2024 12:53
Copy link

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @alinetskyi, @miladz68, and @ysv)


Dockerfile line 5 at r2 (raw file):

RUN apk update
RUN apk add postgresql
COPY ./bin/.cache/bdjuno/docker.linux.amd64/bin/bdjuno /usr/bin/bdjuno

Why do you copy the amd64 if the build can be for `linux/amd64,linux/arm64 architectures?

@alinetskyi alinetskyi force-pushed the fix_build branch 3 times, most recently from 5b94b68 to 7046e8c Compare July 1, 2024 11:40
Copy link
Collaborator Author

@alinetskyi alinetskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @ysv)


Dockerfile line 5 at r2 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Why do you copy the amd64 if the build can be for `linux/amd64,linux/arm64 architectures?

Done.

@alinetskyi alinetskyi requested a review from dzmitryhil July 1, 2024 20:25
miladz68
miladz68 previously approved these changes Jul 2, 2024
Copy link

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil and @ysv)

Copy link

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alinetskyi and @ysv)


Dockerfile line 5 at r2 (raw file):

Previously, alinetskyi (Artem Linetskiy) wrote…

Done.

Actually we need both

@alinetskyi alinetskyi force-pushed the fix_build branch 6 times, most recently from 2d38c6f to 32d3f12 Compare July 2, 2024 20:42
Copy link
Collaborator Author

@alinetskyi alinetskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @ysv)


Dockerfile line 5 at r2 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Actually we need both

Done.

Copy link

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)

Copy link

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@alinetskyi alinetskyi merged commit 5acfedf into chains/coreum Jul 3, 2024
2 checks passed
@dzmitryhil dzmitryhil deleted the fix_build branch January 8, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants