Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated function get_io_service() is removed in asio 1.13.0 #370

Closed
Rastaban opened this issue Apr 25, 2019 · 8 comments
Closed

deprecated function get_io_service() is removed in asio 1.13.0 #370

Rastaban opened this issue Apr 25, 2019 · 8 comments
Assignees
Milestone

Comments

@Rastaban
Copy link

Just wanted to give you a heads up that the 1.13.0 release of asio removes a few previously deprecated member functions that are used in restbed. See their release notes http://think-async.com/Asio/asio-1.13.0/doc/asio/history.html#asio.history.asio_1_13_0.

@ben-crowhurst
Copy link
Member

Thanks for the notice, will roll out an updated build shortly.

@JackBoosY
Copy link

JackBoosY commented Oct 30, 2019

@ben-crowhurst Any progress?

The function get_io_service can be replaced with get_executor().context()(#252), but I don't know which function can be replaced by run_one.

Related: #8880.

@ben-crowhurst
Copy link
Member

ben-crowhurst commented Feb 8, 2020

We've upgraded the 4.7 branch to the latest 1.12.* release. Tackling ASIO 1.13.0 will require significant surgery and we're on track for 1.13.0 to be a major enchancement of the 4.8 release.

@ben-crowhurst ben-crowhurst self-assigned this Feb 8, 2020
@ben-crowhurst ben-crowhurst added this to the 4.8 milestone Feb 8, 2020
@JackBoosY
Copy link

@ben-crowhurst Thanks for reply, if this problem is fixed, please let me know. I will update restbed in vcpkg.

Thanks.

@ben-crowhurst
Copy link
Member

I'll let you know, thanks.

@fxfire
Copy link

fxfire commented May 8, 2020

I upped just yesterday to ASIO 1.16.1 aka latest and had to replace only 4 spots in restbed with what was already said above,
get_io_service can be replaced with get_executor().context()

all works fine

@JackBoosY
Copy link

The latest version not working with asio 1.18.0.

@ben-crowhurst
Copy link
Member

Pushed dependency to 1.18.2 .

maggu2810 pushed a commit to maggu2810/restbed that referenced this issue Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants