Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make instantiate export optional #1927

Closed
webmaster128 opened this issue Oct 19, 2023 · 2 comments · Fixed by #1933
Closed

Make instantiate export optional #1927

webmaster128 opened this issue Oct 19, 2023 · 2 comments · Fixed by #1933
Milestone

Comments

@webmaster128
Copy link
Member

webmaster128 commented Oct 19, 2023

At some point there might be contracts that don't need an instantiate entry point. At the moment, calling Instantiate in wasmd requires it. But other callers or future wasmds can be more flexible. To prepare for this, we should remove the requirement for instantitate from the static validation. This changes some error cases from the StoreCode step to the Instantiate step, but this is not super bad.

Once it is optional, we should have a dev contract without the endpoint and create a test that shows how Instantiate in wasmvm behaves when the entry point is missing.

@chipshort
Copy link
Collaborator

One problem I encountered here: cosmwasm-schema currently requires an instantiate message and changing it is technically a breaking change because Api is public. Not sure if anyone is using it directly though.
I can create the contract with an Empty instantiate msg in the schema or without schema for now and we can make it optional in cosmwasm-schema 2.0

@webmaster128
Copy link
Member Author

Okay great. In this case let's push the whole ticket into 2.0. It's not urgent enough to justify headaches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants