Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make instantiate optional #1933

Merged
merged 11 commits into from
Nov 13, 2023
Merged

Make instantiate optional #1933

merged 11 commits into from
Nov 13, 2023

Conversation

chipshort
Copy link
Collaborator

closes #1927

This does the following:

  • Remove the instantiate export check from static analysis
  • Adds the new empty contract that has basically nothing in it and uses that in some tests
  • Changes cosmwasm-schema to make instantiate optional.

webmaster128
webmaster128 reviewed Oct 30, 2023
View reviewed changes
contracts/empty/src/lib.rs Outdated Show resolved Hide resolved
packages/vm/src/compatibility.rs Show resolved Hide resolved
contracts/empty/README.md Show resolved Hide resolved
@chipshort chipshort force-pushed the 1927-make-instantiate-optional branch from 1075324 to 1698f7a Compare October 31, 2023 09:15
webmaster128
webmaster128 reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. Just two small things and a CHANGELOG entry

packages/schema-derive/src/generate_api.rs Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
contracts/README.md Show resolved Hide resolved
webmaster128
webmaster128 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, just CHANGELOG and then go

@chipshort chipshort force-pushed the 1927-make-instantiate-optional branch from 73039ed to 37a1735 Compare November 13, 2023 11:58
@chipshort chipshort merged commit 88762e8 into main Nov 13, 2023
4 of 5 checks passed
@chipshort chipshort deleted the 1927-make-instantiate-optional branch November 13, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make instantiate export optional
2 participants
@chipshort @webmaster128