-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle QueryMsg
with generics when deriving the QueryResponses
trait
#1429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only understand half of the magic but looks solid. Can you add a CHANGELOG entry?
0fd2f5c
to
7c6e173
Compare
CHANGELOG.md
Outdated
|
||
[#1426]: https://github.com/CosmWasm/cosmwasm/issues/1426 | ||
[#1429]: https://github.com/CosmWasm/cosmwasm/issues/1429 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the PR number, not the issue number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, fair. I only tested that the link works
}; | ||
|
||
let result = query_responses_derive_impl(input); | ||
dbg!(&result); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover.
Closes #1424