Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Use Into<Self> for all full_mul impls #1874

Merged
merged 2 commits into from
Oct 18, 2023
Merged

[2.0] Use Into<Self> for all full_mul impls #1874

merged 2 commits into from
Oct 18, 2023

Conversation

chipshort
Copy link
Collaborator

closes #1433

webmaster128
webmaster128 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just the changelog

@chipshort chipshort force-pushed the 1433-full-mul-consistency branch from ced7859 to 7ae1d73 Compare October 18, 2023 09:05
@chipshort chipshort force-pushed the 1433-full-mul-consistency branch from 7ae1d73 to 79d610c Compare October 18, 2023 09:12
@chipshort chipshort merged commit b1c031a into main Oct 18, 2023
@chipshort chipshort deleted the 1433-full-mul-consistency branch October 18, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UintXX:full_mul consistency
2 participants
@chipshort @webmaster128