Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Add memo field to IbcMsg::Transfer #1878

Merged
merged 6 commits into from
Oct 30, 2023
Merged

[2.0] Add memo field to IbcMsg::Transfer #1878

merged 6 commits into from
Oct 30, 2023

Conversation

chipshort
Copy link
Collaborator

closes #1477

webmaster128
webmaster128 reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an interesting approach for a better Rust API using an Option: https://github.com/CosmWasm/cosmwasm/pull/1757/files. One in Go, there is no difference between None and "" anymore. But Option might be a nicer way of skipping. What do you think about it? (The type needs to be String instead of Binary in any case)

@chipshort
Copy link
Collaborator Author

I think Option is more rusty. 👍

@chipshort chipshort force-pushed the 1477-ibc-transfer-memo branch from a6ddea1 to 9e21260 Compare October 17, 2023 12:23
@chipshort chipshort force-pushed the 1477-ibc-transfer-memo branch from b8ac07b to 5bda166 Compare October 17, 2023 14:58
@webmaster128 webmaster128 mentioned this pull request Oct 18, 2023
Closed
webmaster128
webmaster128 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just the CHANGELOG entry

@chipshort chipshort force-pushed the 1477-ibc-transfer-memo branch from 5bda166 to eb2c9ce Compare October 30, 2023 09:35
@chipshort chipshort merged commit fde26bd into main Oct 30, 2023
5 checks passed
@chipshort chipshort deleted the 1477-ibc-transfer-memo branch October 30, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IBC TransferMsg: add memo field
2 participants
@chipshort @webmaster128