[1.5] Deprecate compact serialization of Binary, HexBinary

CHANGELOG.md

@@ -22,9 +22,12 @@ and this project adheres to
 
 - cosmwasm-std: Let `Timestamp::plus_nanos`/`::minus_nanos` use
   `Uint64::strict_add`/`::strict_sub` and document overflows. ([#2098], [#2107])
+- cosmwasm-std: Deprecate "compact" serialization of `Binary`, `HexBinary`,
+  `Checksum` ([#2126])
 
 [#2098]: https://github.com/CosmWasm/cosmwasm/pull/2098
 [#2107]: https://github.com/CosmWasm/cosmwasm/pull/2107
+[#2126]: https://github.com/CosmWasm/cosmwasm/pull/2126
 
 ### Fixed
 

packages/std/src/binary.rs

@@ -214,7 +214,11 @@
     where
         S: ser::Serializer,
     {
-        serializer.serialize_str(&self.to_base64())
+        if serializer.is_human_readable() {
+            serializer.serialize_str(&self.to_base64())
+        } else {
+            panic!("Binary is only intended to be used with JSON serialization for now. If you are hitting this panic please open an issue at https://github.com/CosmWasm/cosmwasm describing your use case.")
+        }
     }
 }
 
@@ -224,7 +228,11 @@
     where
         D: Deserializer<'de>,
     {
-        deserializer.deserialize_str(Base64Visitor)
+        if deserializer.is_human_readable() {
+            deserializer.deserialize_str(Base64Visitor)
+        } else {
+            panic!("Binary is only intended to be used with JSON serialization for now. If you are hitting this panic please open an issue at https://github.com/CosmWasm/cosmwasm describing your use case.")
+        }
     }
 }
 

packages/std/src/hex_binary.rs

@@ -209,7 +209,11 @@
     where
         S: ser::Serializer,
     {
-        serializer.serialize_str(&self.to_hex())
+        if serializer.is_human_readable() {
+            serializer.serialize_str(&self.to_hex())
+        } else {
+            panic!("HexBinary is only intended to be used with JSON serialization for now. If you are hitting this panic please open an issue at https://github.com/CosmWasm/cosmwasm describing your use case.")
+        }
     }
 }
 
@@ -219,7 +223,11 @@
     where
         D: Deserializer<'de>,
     {
-        deserializer.deserialize_str(HexVisitor)
+        if deserializer.is_human_readable() {
+            deserializer.deserialize_str(HexVisitor)
+        } else {
+            panic!("HexBinary is only intended to be used with JSON serialization for now. If you are hitting this panic please open an issue at https://github.com/CosmWasm/cosmwasm describing your use case.")
+        }
     }
 }