make order (de)serialize #2174
Merged
make order (de)serialize #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the appropriate derive attributes so that the `Order` type can be sent in messages
chipshort
reviewed
Jun 17, 2024
|
How is that type serialzed in JSON? Could you add a test and an entry to https://github.com/CosmWasm/cosmwasm/blob/main/docs/MESSAGE_TYPES.md? |
dakom
added a commit
to dakom/cosmwasm
that referenced
this pull request
Jun 24, 2024
Fixes comment at CosmWasm#2174 (comment)
"ascending" or "descending"
Done in #2177 |
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the appropriate derive attributes
so that the
Ordertype can be sent in messages