-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default impl for Storage::range
#2197
Conversation
Should we return an empty range or should we panic with cosmwasm/packages/std/src/traits.rs Lines 188 to 194 in 7df4a7b
I'm not sure how I feel about silently failing with a technically incorrect default value, we should probably crash loudly, letting them know something's up |
Yeah let's create a panicking implementation. We might even want to use a helpful panic message if it is optimized out if iterator is set. |
Good point. I agree it's probably better to panic here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have a CHANGELOG entry, but change looks good to me
first step of #2193