Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cosmwasm_vm::testing module #339

Merged
merged 2 commits into from
May 18, 2020
Merged

Use cosmwasm_vm::testing module #339

merged 2 commits into from
May 18, 2020

Conversation

webmaster128
Copy link
Member

Follow-up of #331

  • in cosmwasm-vm, rename MemoryStorage to MockStorage since it is not reused anymore
  • in cosmwasm-vm, export everything that is related to testing (such as the mock stuff) in the cosmwasm_vm::testing module, like we do in cosmwasm-std

@webmaster128 webmaster128 requested a review from ethanfrey May 18, 2020 16:00
ethanfrey
ethanfrey approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup and separation of test code from production code.

@webmaster128 webmaster128 merged commit 01d7d13 into master May 18, 2020
@webmaster128 webmaster128 deleted the use-testing-module branch May 18, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webmaster128 @ethanfrey