Remove MessageInfo argument from migrate entry point

[juggernaut09]

Closes #690

• Changed the function signature of fn migrate as fn query. (Removed the MessageInfo). in both hackatom and burner contracts.
• Changed the struct member verifier to payout as referenced by @webmaster128. in hackatom contract.
• Updated the json schema of MigrateMsg (migrate_msg.json) in hackatom contract.
• Update the entry points, both the macro(packages/std/src/entry_points.rs) and as well as the wrapper(packages/std/src/exports.rs).

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x//spec/)
• Added relevant rustdoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer
• Review Codecov Report in the comment section below once CI passes

[webmaster128]

Looks good to me. Could you rebase this work to the latest master?

[ethanfrey]

Thanks for the contribution

[juggernaut09]

Looks good to me. Could you rebase this work to the latest master?

@webmaster128 can you please review it again. I have rebased it to latest master branch. Solved merge conflicts also.

[ethanfrey]

Looks good to me. I would just add a CHANGELOG entry "removed info argument from migrate".
But Simon need to give the ✔️ to merge

[webmaster128]

Looks good, except for this diff in Building.md.

Would you also do #715? Ideally we do #715 first (independent PR) because it will ensure the change here works as expected.

[webmaster128]

Looks good, thank you.

Now, why is #715 important? This PR (#709) changes the interface between VM and contract. The testing contract in packages/vm/testdata/hackatom_0.14.wasm is still the old one, i.e. incompatible. So updating packages/vm/testdata/hackatom_0.14.wasm should be required as part of this. However, this interface is not tested so this incompatibility is not detected by th CI.

[juggernaut09]

Looks good, thank you.

Now, why is #715 important? This PR (#709) changes the interface between VM and contract. The testing contract in packages/vm/testdata/hackatom_0.14.wasm is still the old one, i.e. incompatible. So updating packages/vm/testdata/hackatom_0.14.wasm should be required as part of this. However, this interface is not tested so this incompatibility is not detected by th CI.

Ohk @webmaster128 I will work on the issue #715 and raise a PR.

[webmaster128]

Could you update this to the latest master (rebase or merge master into this). This probably leads to one failing test. We then re-compile the testing contract to make it work again.

[juggernaut09]

Could you update this to the latest master (rebase or merge master into this). This probably leads to one failing test. We then re-compile the testing contract to make it work again.

@webmaster128 I have tried to remove info: MessageInfo from fn call_migrate_works in packages/vm/src/calls.rsIt is raising a signature error because of passing only env and msg to call_raw. as below
call_raw(instance, "migrate", &[env, msg], MAX_LENGTH_MIGRATE)

The error is Parameters of type [I32, I32] did not match signature [I32, I32, I32] -> [I32]"
It is causing by the following code snippet.
https://github.com/wasmerio/wasmer/blob/1.0.1/lib/api/src/externals/function.rs#L500-L506

[webmaster128]

@juggernaut09 right, this is because the test contract packages/vm/testdata/hackatom_0.14.wasm needs to be recompiled when the interface between VM and contract changes. You can do this as followes (see https://github.com/CosmWasm/cosmwasm/blob/master/packages/vm/README.md#setup):

docker run --rm -v "$(pwd)":/code \
  --mount type=volume,source="devcontract_cache_hackatom",target=/code/contracts/hackatom/target \
  --mount type=volume,source=registry_cache,target=/usr/local/cargo/registry \
  cosmwasm/rust-optimizer:0.10.7 ./contracts/hackatom \
  && cp artifacts/hackatom.wasm packages/vm/testdata/hackatom_0.14.wasm

After that, it should work. You will have to update some gas values in the tests after recompiling.

[webmaster128]

Looks good to me. Just the debug print

[webmaster128]

Thanks a lot for your contribution, @juggernaut09