Crypto api #767
Closed
Crypto api #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include non low-S signatures normalization
Closed
|
Great to see this working as an intermediate step. Closing as #770 is a superiour alternative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes first part of #751. Proof of concept secp256k1 signature verification, for Cosmos signatures.
Based on the
secp256k1crate, which is a wrapper around libsecp256k1, a C library by Pieter Wuille for producing ECDSA signatures using the SECG curve secp256k1.I don't think we'll end up merging this, as after talks I'm now working on a new impl, based on the
k256crate. Which, besides being Rust-only, includes support fored25519and the hash algorithm Ethereum uses (keccak256).So, we'll in principle have an all-in-one, Rust-only solution with that crate.
Creating as Draft PR anyway. For feedback / reviews, and also for reference / future uses.