Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crypto api ed25519 #771

Merged
merged 47 commits into from
Feb 17, 2021
Merged

Crypto api ed25519 #771

merged 47 commits into from
Feb 17, 2021

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Feb 5, 2021 •
edited
Loading

Closes #755.

  • ed25519 imports / api
  • imports / api tests
  • improve documentation
  • contract tests

Update: Rebased against crypto-api-package. Ready for review.

Update 2: Rebased against latest crypto-api-package. Added contract tests.

@maurolacy maurolacy self-assigned this Feb 5, 2021
webmaster128
webmaster128 reviewed Feb 5, 2021
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some first thoughts. Looks like this is easy once secp256k1 is done.

packages/vm/src/crypto.rs Outdated Show resolved Hide resolved
packages/vm/src/crypto.rs Outdated Show resolved Hide resolved
packages/vm/src/crypto.rs Outdated Show resolved Hide resolved
packages/vm/src/crypto.rs Outdated Show resolved Hide resolved
@maurolacy maurolacy force-pushed the crypto-api-ed25519 branch 3 times, most recently from ff8d608 to d998288 Compare February 8, 2021 21:06
@maurolacy maurolacy force-pushed the crypto-api-rust-only branch 3 times, most recently from f0501ea to 25eecd4 Compare February 9, 2021 10:51
@maurolacy maurolacy force-pushed the crypto-api-ed25519 branch 4 times, most recently from 27d40e3 to 78ed1dd Compare February 12, 2021 13:39
@maurolacy maurolacy marked this pull request as ready for review February 12, 2021 13:51
@maurolacy maurolacy changed the base branch from crypto-api-rust-only to crypto-api-package February 12, 2021 13:54
@maurolacy maurolacy force-pushed the crypto-api-ed25519 branch 3 times, most recently from 143431b to f1d389c Compare February 17, 2021 07:05
@maurolacy
Add ed25519 native api tests
a0365c9
@maurolacy
Add verify_ed25519 native
63299ac
@maurolacy
Fix ed25519_verify signature
3ead8f8
@maurolacy
Add ed25519_verify MockApi impl
1950ed6
@maurolacy
Add (mock) API ed25519 (basic) tests
c0ce241
@maurolacy
Update crypto-verify lock file
d2c90ab
@maurolacy
Add ed25519_verify documentation
9169eab
@maurolacy
Update crypto package README.md
4ff7a7b
@maurolacy
Update README.md / CHANGELOG.md
f1bffbd
@maurolacy
Adapt ed25519_verify to VerificationError
67cadd1
@maurolacy
Add ed25519_verify to Api trait
0543093 
Add dummy ed25519_verify mock
@maurolacy
Add ed25519 checks / limits
fe424b2 
Adapt/extend constants names
@maurolacy
Add (mock) API ed25519 (basic) tests
bb560d8
@maurolacy
Add crypto-verify contract ed25519 support
81e1624
@maurolacy
Add ed25519 integration tests
5bc28fc
@maurolacy
Update schema
075be09
@maurolacy
Remove duplicate tests (rebase errors)
b0e3630
@maurolacy
Adapt crypto-verify contract ed25519 support to VerificationError
accf545
Base automatically changed from crypto-api-package to main February 17, 2021 10:06
webmaster128
webmaster128 reviewed Feb 17, 2021
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

contracts/crypto-verify/src/contract.rs Outdated Show resolved Hide resolved
contracts/crypto-verify/src/contract.rs Show resolved Hide resolved
packages/crypto/src/crypto.rs Outdated Show resolved Hide resolved
packages/crypto/src/lib.rs Outdated Show resolved Hide resolved
packages/crypto/src/crypto.rs Outdated Show resolved Hide resolved
@webmaster128 webmaster128 merged commit d458953 into main Feb 17, 2021
@webmaster128 webmaster128 deleted the crypto-api-ed25519 branch February 17, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

@ethanfrey ethanfrey Awaiting requested review from ethanfrey

Assignees

@maurolacy maurolacy

Labels
Crypto APIs (AssemblyScript Reallocation)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support ed25519 signature verification (e.g. Tendermint block headers)
2 participants
@maurolacy @webmaster128